Skip to content

refactor(delegation): move impl Pallet into pallet mod#428

Merged
weichweich merged 2 commits intodevelopfrom
aw-refactor-delegation
Oct 24, 2022
Merged

refactor(delegation): move impl Pallet into pallet mod#428
weichweich merged 2 commits intodevelopfrom
aw-refactor-delegation

Conversation

@weichweich
Copy link
Contributor

No Ticket

Move the Pallet impl block into the pallet module like we do it for all other pallets as well.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich requested a review from wischli October 24, 2022 08:18
@weichweich weichweich self-assigned this Oct 24, 2022
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichweich weichweich enabled auto-merge (squash) October 24, 2022 08:23
@weichweich weichweich merged commit 70f3c5d into develop Oct 24, 2022
@weichweich weichweich deleted the aw-refactor-delegation branch October 24, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants