Skip to content

refactor: remove custom serde derivation for DID types#429

Merged
wischli merged 3 commits intodevelopfrom
wf-fix-didapi-decoding
Oct 28, 2022
Merged

refactor: remove custom serde derivation for DID types#429
wischli merged 3 commits intodevelopfrom
wf-fix-didapi-decoding

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Oct 27, 2022

Connected to https://github.com/KILTprotocol/ticket/issues/2235

  • Removes custom (de-)serialization for DID types

On a note: scale-info has a feature flag serde which automatically adds serde derivation to the corresponding type. Thus, we don’t have to add our own custom serde derives for those types anymore.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested review from ntn-x2 and weichweich October 27, 2022 11:07
@wischli wischli self-assigned this Oct 27, 2022
@wischli wischli added this to the 1.8.0 milestone Oct 27, 2022
Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 🧹🧹🧹

@wischli wischli added 🛑 dont-merge DONT MERGE and removed 🛑 dont-merge DONT MERGE labels Oct 28, 2022
@wischli wischli merged commit 4d66220 into develop Oct 28, 2022
@wischli wischli deleted the wf-fix-didapi-decoding branch October 28, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants