Conversation
ntn-x2
force-pushed
the
aa/toolchain-update
branch
from
ed3ce31 to
d215bea
Compare
weichweich
approved these changes
Nov 29, 2022
wischli
approved these changes
Nov 29, 2022
Contributor
wischli
left a comment
wischli
left a comment
There was a problem hiding this comment.
LGTM but I have a remark, see below.
rust-toolchain.toml
Outdated
| @@ -1,3 +1,4 @@ | |||
| [toolchain] | |||
| channel = "nightly-2022-07-24" | |||
| channel = "nightly-2022-11-29" | |||
Contributor
There was a problem hiding this comment.
Im not in favor of using a newer version than in the last Polkadot release. But we could try until we run into some weird compilation errors.
Contributor
Author
There was a problem hiding this comment.
Yeah good point. Polkadot 0.9.31 uses one from late October, which is good enough for us. I updated that in de04e4b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rust-analyzer has been merged into the main rustlang repo, it is tested for breaking changes. This means that we don't need to pin the nightly to a specific version anymore, as using the latest nightly is always guaranteed to work with the latest version of the rust-analyzer extension (try it yourselves, for me it finally just works).
This PR then does the following:
cargo-features = ["workspace-inheritance"], since from 1.64 it has been stabilised (this could be caught only by using a recent enough nightly version)+nightlyflag. This will ensure we have a consistent behaviour between local machine and CI server.The only thing to consider is that the nightly will differ from the version that srtool uses to build the runtime WASM. That was the case also before, and it will always be until substrate will support compilation with the stable toolchain.