Skip to content

chore: make clear that it's still under development#451

Merged
weichweich merged 1 commit intodevelopfrom
aw-ensure-under-dev
Jan 20, 2023
Merged

chore: make clear that it's still under development#451
weichweich merged 1 commit intodevelopfrom
aw-ensure-under-dev

Conversation

@weichweich
Copy link
Contributor

@weichweich weichweich commented Jan 20, 2023

fixes https://github.com/KILTprotocol/ticket/issues/2387

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich requested a review from ntn-x2 January 20, 2023 09:38
@ntn-x2
Copy link
Contributor

ntn-x2 commented Jan 20, 2023

Is this a new convention we are adopting?

Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see there's a ticket for it. LGTM!

@weichweich weichweich merged commit 79ac365 into develop Jan 20, 2023
@weichweich weichweich deleted the aw-ensure-under-dev branch January 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants