Conversation
ntn-x2
commented
Jan 25, 2023
| /// the dispatch Origin. | ||
| pub type LocationToAccountId<RelayNetwork> = ( | ||
| // The parent (Relay-chain) origin converts to the parent `AccountId`. | ||
| pub type LocationToAccountId<NetworkId> = ( |
Contributor
Author
There was a problem hiding this comment.
The generic refers to a network ID. So especially for the future it is clearer to give the generic the proper name.
| // Balances pallet here. Balances is only used if fees are dropped without being | ||
| // used. In that case they are put into the treasury. | ||
| type Trader = UsingComponents<WeightToFee<Runtime>, RelayLocation, AccountId, Balances, Treasury>; | ||
| type Trader = UsingComponents<WeightToFee<Runtime>, HereLocation, AccountId, Balances, Treasury>; |
Contributor
Author
There was a problem hiding this comment.
We allow unpaid execution from the relay chain. Plus, here we were saying that relay chain funds could be used to pay for the fees, when nothing else was allowed. I think keeping it local for now is the most logical choice. We will open up once we open up to other chains.
weichweich
approved these changes
Jan 26, 2023
Contributor
weichweich
left a comment
weichweich
left a comment
There was a problem hiding this comment.
LGTM... the seem to make sense.
I guess this was copied from statemine or similar when this was added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were few things that, as far as I have understood, were not 100% consistent with what the chain does and especially does NOT do, right now. More details are provided as comments in the files.