Conversation
weichweich
suggested changes
Apr 6, 2023
Contributor
weichweich
left a comment
weichweich
left a comment
There was a problem hiding this comment.
Let's remove the insecure pallet
runtimes/peregrine/Cargo.toml
Outdated
| pallet-preimage.workspace = true | ||
| pallet-proxy.workspace = true | ||
| pallet-randomness-collective-flip.workspace = true | ||
| pallet-insecure-randomness-collective-flip.workspace = true |
Contributor
There was a problem hiding this comment.
This pallet is not needed here. I think the renaming should also make it clear that we should remove it. :D
runtimes/spiritnet/src/lib.rs
Outdated
| { | ||
| System: frame_system = 0, | ||
| RandomnessCollectiveFlip: pallet_randomness_collective_flip = 1, | ||
| RandomnessCollectiveFlip: pallet_insecure_randomness_collective_flip = 1, |
Contributor
There was a problem hiding this comment.
Let's remove this please
Contributor
Author
There was a problem hiding this comment.
Same as above, plus a cleanup PR: ac9ab1f
weichweich
reviewed
Apr 12, 2023
weichweich
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #495.
Since the
wasmtimedependency has been bumped from 1.x to 6.x, the old nightly was not good anymore since some inline stuff the new crate is using was still not stable back then. Hence, I bumped the nightly to a more recent version. Nevertheless, it cannot be TOO recent because of this issue (which maybe has been fixed in 0.9.40 @weichweich?).Anyway, updating to the new toolchain version added a whole bunch of Clippy warnings which I also addressed in this PR, among which there was one about the wrong declaration of the
parity-scale-codecpackage, which I have now used with its original name everywhere, instead of aliasing it tocodec.