Conversation
Ad96el
changed the title
ntn-x2
reviewed
Jul 24, 2023
Contributor
ntn-x2
left a comment
ntn-x2
left a comment
There was a problem hiding this comment.
A couple of minor questions, before I can approve the PR!
…node into chore/polkadot-0.9.43
ntn-x2
approved these changes
Jul 24, 2023
weichweich
approved these changes
Jul 25, 2023
Contributor
weichweich
left a comment
weichweich
left a comment
There was a problem hiding this comment.
LGTM
Was the http based RPC port removed? Is there no RPC over HTTP anymore? only websockets?
Contributor
Author
|
@weichweich the RPC server supports websocket and HTTP on the same socket. The HTTP was kept for backwards compatibility so yes in the future there should be only WS. Source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#513
RemoveInsecureRandomnessPalleteven if it is no longer useful 👻