Conversation
ntn-x2
force-pushed
the
aa/docs-check
branch
from
8d43921 to
5b6d69e
Compare
weichweich
approved these changes
Nov 21, 2023
ntn-x2
added a commit
that referenced
this pull request
Dec 6, 2023
Fixes https://github.com/KILTprotocol/ticket/issues/2560. - [x] ~WIP.~ To rebase on top of #583 once merged. --------- Co-authored-by: Chris Chinchilla <chris@chrischinchilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
cargo docproduces a bunch of warnings. Although we don't do much with them yet, it is nice that we make sure they are correct. Our test step already includes any snippets (we don't have any), but we don't check that the docs themselves are correct.