chore: mocks for bonding curve pallet#780
Merged
Ad96el merged 15 commits intopallet_bonded_coinsfrom Nov 5, 2024
Merged
Conversation
Ad96el
changed the title
rflechtner
reviewed
Nov 4, 2024
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
For the most part I have no idea what's going on here, but good job I guess? 
ntn-x2
reviewed
Nov 5, 2024
ntn-x2
reviewed
Nov 5, 2024
| pub(crate) fn calculate_pool_id(currencies: Vec<AssetId>) -> AccountId { | ||
| AccountId::from(currencies.blake2_256()) | ||
| pub(crate) fn calculate_pool_id(currencies: &[AssetId]) -> AccountId { | ||
| AccountId::from(currencies.to_vec().blake2_256()) |
Contributor
There was a problem hiding this comment.
Oh, does the blake2_256() function require ownership? I've used it via the Hash trait it only took a reference to a byte array. Anyway, this is minor stuff.
rflechtner
reviewed
Nov 5, 2024
rflechtner
reviewed
Nov 5, 2024
rflechtner
reviewed
Nov 5, 2024
This reverts commit cb1bdd5.
rflechtner
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some mocks for testing + benchmarking