fix: do not compute terms if we know the result to be 0#817
Merged
rflechtner merged 5 commits intobonded-coins-audit-fixesfrom Mar 10, 2025
Merged
fix: do not compute terms if we know the result to be 0#817rflechtner merged 5 commits intobonded-coins-audit-fixesfrom
rflechtner merged 5 commits intobonded-coins-audit-fixesfrom
Conversation
rflechtner
commented
Nov 28, 2024
pallets/pallet-bonded-coins/src/tests/transactions/mint_into.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@Ad96el do you think we'd have to make changes to benchmarking for this? |
rflechtner
force-pushed
the
rf-less-overflow-on-polynomial
branch
from
e6d513f to
50f3ccf
Compare
rflechtner
force-pushed
the
rf-less-overflow-on-polynomial
branch
from
50f3ccf to
121c870
Compare
ntn-x2
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/3807
This means we don't compute the overflowing quadratic terms if we do not need the result.
Checklist:
array[3]useget(3), ...)