fix: make sure the reset_team trait actually sets the owner#865
Merged
rflechtner merged 8 commits intobonded-coins-audit-fixesfrom Mar 10, 2025
Merged
fix: make sure the reset_team trait actually sets the owner#865rflechtner merged 8 commits intobonded-coins-audit-fixesfrom
rflechtner merged 8 commits intobonded-coins-audit-fixesfrom
Conversation
Contributor
Author
|
@ntn-x2 pinging you to have a look at this issue. What do you think about the implementation of ownership change? |
ntn-x2
reviewed
Mar 7, 2025
| _(origin as T::RuntimeOrigin, pool_id, fungibles_team, max_currencies); | ||
| _( | ||
| origin as T::RuntimeOrigin, | ||
| pool_id.clone(), |
Contributor
There was a problem hiding this comment.
Do not clone() as part of the benchmark itself, but do it before.
ntn-x2
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3802
Changes the reset_team trait to actually set the owner passed to the function.
The trait implementation is a back-port of a trait implemented in latest versions of pallet-assets (https://docs.rs/pallet-assets/41.0.0/pallet_assets/pallet/struct.Pallet.html#impl-ResetTeam%3C%3CT+as+Config%3E::AccountId%3E-for-Pallet%3CT,+I%3E). Changing ownership of an asset is part of this trait but was not implemented here as not needed.
Nevertheless, we're adding this now to avoid mismatched expectations.
TBD
Checklist:
array[3]useget(3), ...)