Skip to content

feat: disallow re-using token names and symbols within a pool#870

Merged
rflechtner merged 5 commits intobonded-coins-audit-fixesfrom
audit-issue-8
Mar 10, 2025
Merged

feat: disallow re-using token names and symbols within a pool#870
rflechtner merged 5 commits intobonded-coins-audit-fixesfrom
audit-issue-8

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Mar 6, 2025

fixes https://github.com/KILTprotocol/ticket/issues/3803

Disallows re-using the same token symbol or name. Empty names and symbols are always allowed.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner requested a review from ntn-x2 March 6, 2025 14:58
@rflechtner
Copy link
Contributor Author

Failing tests suggest that HashSet is not available to be used in the runtime, so I replaced it with BTreeSet

@rflechtner rflechtner merged commit 7793ece into bonded-coins-audit-fixes Mar 10, 2025
14 of 15 checks passed
@rflechtner rflechtner deleted the audit-issue-8 branch March 10, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants