fix: do not allow lock states that are equivalent to unlocked by rflechtner · Pull Request #871 · KILTprotocol/kilt-node

rflechtner · 2025-03-06T16:42:55Z

fixes https://github.com/KILTprotocol/ticket/issues/3806

I have verified that the code works
- No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
I have left the code in a better state
I have documented the changes (where applicable)
- Either PR or Ticket to update the Docs
- Link the PR/Ticket here

pallets/pallet-bonded-coins/src/lib.rs

fix: do not allow lock states that are equivalent to unlocked

9762f66

rflechtner requested a review from ntn-x2 March 6, 2025 16:43

ntn-x2 approved these changes Mar 7, 2025

View reviewed changes

pallets/pallet-bonded-coins/src/lib.rs Outdated Show resolved Hide resolved

rflechtner added 2 commits March 10, 2025 11:02

refactor: do not instantiate locks object to check for any lock set

fa4bde3

chore: make method const

f3c8b6c

rflechtner merged commit 3e37282 into bonded-coins-audit-fixes Mar 10, 2025
13 of 15 checks passed

rflechtner deleted the audit-issue-11 branch March 10, 2025 12:31