Conversation
Ad96el
requested review from
abdulmth and
rflechtner
and removed request for
abdulmth and
rflechtner
Contributor
Author
|
I decided to add the benchmarking in this PR. |
rflechtner
reviewed
Apr 23, 2025
abdulmth
approved these changes
Apr 30, 2025
ntn-x2
reviewed
May 7, 2025
Contributor
ntn-x2
left a comment
ntn-x2
left a comment
There was a problem hiding this comment.
Minor things. Also, it seems the PR description is outdated, since I can't see where the staking pallet is being used? Session length has a fixed duration now, so the only thing that the staking pallet does, is to provide collators until there is a well formed collator set (meaning non empty and with all session keys set) that is returned by the new session manager.
|
|
||
| if collators.is_empty() || !has_collator_keys { | ||
| // we never want to pass an empty set of collators. This would brick the chain. | ||
| log::error!("💥 keeping old session because of empty collator set!"); |
Contributor
There was a problem hiding this comment.
I think a different error message depending on which condition is false would massively reduce headaches in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3822
This PR introduces permissioned collators to the Peregrine and Spirtinet runtimes. The council or governance is now allowed to add and remove members through the newly deployed pallet-membership. This pallet is then used by a new session manager implementation. The old session manager implementation remains untouched—it's only moved out of the runtime.
After the migration, the parachain-staking pallet becomes essentially obsolete, as collators no longer receive rewards for block production.
A follow-up PR will reduce rewards in the parachain-staking pallet accordingly.
The round information (which determines session length) still resides in the parachain-staking pallet. Before it can be removed, a new source for round length must be implemented—either directly in the runtime or via a custom pallet that includes collator information.
How to test