Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

feat: use aws documentdb#106

Merged
tjwelde merged 3 commits intodevelopfrom
tw-1023-use-documentdb
Feb 12, 2021
Merged

feat: use aws documentdb#106
tjwelde merged 3 commits intodevelopfrom
tw-1023-use-documentdb

Conversation

@tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Feb 11, 2021 •
edited
Loading

relates to KILTProtocol/ticket#1023

This PR allows to connect to AWS DocumentDB, instead of a normal mongo instance

TODO:

  • Also allow connecting to a local dev mongo instance
  • prepare kubernetes deployment for this PR (ENV variables)
  • switch for ssl support

How to test:

  • Local development with docker-compose mongodb should still work
  • Should also be able to connect to the aws DocumentDB instance (need VPN for testing it)

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@tjwelde tjwelde marked this pull request as ready for review February 12, 2021 09:29
@tjwelde tjwelde merged commit 1221c47 into develop Feb 12, 2021
@tjwelde tjwelde deleted the tw-1023-use-documentdb branch February 12, 2021 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@weichweich weichweich weichweich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjwelde @weichweich