Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

fix: faucet identity key type#120

Merged
tjwelde merged 3 commits intodevelopfrom
tw-fix-faucet
Mar 9, 2021
Merged

fix: faucet identity key type#120
tjwelde merged 3 commits intodevelopfrom
tw-fix-faucet

Conversation

@tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Mar 9, 2021

relates to https://github.com/KILTprotocol/ticket/issues/763

This PR fixes the faucet not giving out tokens, because it needs ed25510 as key algo.

How to test:

  • Get tokens via curl -X POST http://localhost:3000/faucet/drop --data '{"address": "<address>"}' -H "Content-Type: application/json"

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjwelde tjwelde merged commit 963d3f1 into develop Mar 9, 2021
@tjwelde tjwelde deleted the tw-fix-faucet branch March 9, 2021 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants