This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Merged
Conversation
* had to fix the MessagingService interface for this
rflechtner
force-pushed
the
rf-integration-tests
branch
from
345126f to
96b54af
Compare
rflechtner
force-pushed
the
rf-integration-tests
branch
from
1e5ed3c to
135bb4d
Compare
rflechtner
commented
Sep 2, 2020
| @@ -1,6 +1,5 @@ | |||
| import * as dotenv from 'dotenv' | |||
| import * as fs from 'fs' | |||
| import { Injectable } from '@nestjs/common' | |||
rflechtner
commented
Sep 2, 2020
| throw new BadRequestException('bad signature for hash') | ||
| } | ||
| } | ||
| this.contactService.add(contact) |
Contributor
Author
There was a problem hiding this comment.
related to incorrect interfaces
Contributor
There was a problem hiding this comment.
Not sure if this is 100% necessary.
Contributor
Author
There was a problem hiding this comment.
we'd be responding before the request has been fully processed if we don't await. Could silently fail and the requesting party would never know
LeonFLK
approved these changes
Sep 2, 2020
| throw new BadRequestException('bad signature for hash') | ||
| } | ||
| } | ||
| this.contactService.add(contact) |
Contributor
There was a problem hiding this comment.
Not sure if this is 100% necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#617
Adds automated calls to endpoints as integration testing
How to test:
run tests with
yarn test:e2eChecklist: