Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Fix interfaces#74

Merged
LeonFLK merged 3 commits intodevelopfrom
fix-interfaces
Aug 7, 2020
Merged

Fix interfaces#74
LeonFLK merged 3 commits intodevelopfrom
fix-interfaces

Conversation

@LeonFLK
Copy link
Contributor

@LeonFLK LeonFLK commented Aug 7, 2020

fixes the interfaces of the service provider, to represent code behaviour.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@LeonFLK LeonFLK requested a review from rflechtner August 7, 2020 11:56
rflechtner
rflechtner approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonFLK LeonFLK merged commit 8bdaa55 into develop Aug 7, 2020
@rflechtner rflechtner deleted the fix-interfaces branch August 12, 2020 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rflechtner rflechtner rflechtner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LeonFLK @rflechtner