Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

chore: store did as signed DidDocument#80

Merged
LeonFLK merged 1 commit intodevelopfrom
lw-sdk-did
Sep 23, 2020
Merged

chore: store did as signed DidDocument#80
LeonFLK merged 1 commit intodevelopfrom
lw-sdk-did

Conversation

@LeonFLK
Copy link
Contributor

@LeonFLK LeonFLK commented Sep 15, 2020

fixes KILTProtocol/ticket#722 ## fixes KILTProtocol/ticket#687

Removes signature field from storage schema and Contact Interface, and expects stores and returns the did as IDidDocumentSigned.

The demo-client has to be updated to post contacts with updated from.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@LeonFLK LeonFLK requested a review from rflechtner September 15, 2020 14:59
@rflechtner
Copy link
Contributor

we'll be breaking existing did records currently stored in the test net's service database, am I right? Is there any way we could migrate these?

@LeonFLK
Copy link
Contributor Author

LeonFLK commented Sep 15, 2020

If we restart the services, we might lose all data anyway, right?

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonFLK LeonFLK merged commit e6d9dc5 into develop Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants