This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Conversation
tjwelde
force-pushed
the
tw-792-kubernetes
branch
from
0ff5ae3 to
3049237
Compare
tjwelde
force-pushed
the
tw-792-kubernetes
branch
from
5f94641 to
383fbd1
Compare
weichweich
approved these changes
Nov 9, 2020
Contributor
weichweich
left a comment
weichweich
left a comment
There was a problem hiding this comment.
LGTM but we should maybe thing about refactoring some of those things (pushing to AWS, take a Image from AWS and push it to Docker, ...) into a action that can be used in all our projects. Feels like a lot of copy&past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#792
This PR deploys the services to kubernetes automatically
How to test:
Checklist: