This repository was archived by the owner on Jan 5, 2023. It is now read-only.
refactor: faucet status to is in block#86
Merged
Conversation
LeonFLK
suggested changes
Nov 18, 2020
src/faucet/faucet.controller.ts
Outdated
| @@ -76,7 +76,7 @@ export class FaucetController { | |||
| 0 | |||
| ) | |||
| const status = await Blockchain.submitSignedTx(tx) | |||
Contributor
There was a problem hiding this comment.
Calling Blockchain submitSignedTx without any SubscriptionOptions, the resolveOn defaults to IS_FINALIZED
Contributor
There was a problem hiding this comment.
Right now this waits for IS_FINALIZED, and returns true or false dependent on isInBlock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/715
Faucet would take 30 seconds, it should now only take a shorter time due to the changes to status.
How to test:
Spin up and try to use the faucet
Checklist: