This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Conversation
LeonFLK
reviewed
Dec 3, 2020
LeonFLK
suggested changes
Dec 3, 2020
Contributor
LeonFLK
left a comment
LeonFLK
left a comment
There was a problem hiding this comment.
Tests have to be updated 🙄
LeonFLK
approved these changes
Dec 3, 2020
Contributor
LeonFLK
left a comment
LeonFLK
left a comment
There was a problem hiding this comment.
Tests will be fixed separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to KILTProtocol/ticket#851
This PR removes the dependency to github packages and just uses npm as repo.
It also adds another workflow, which can be triggered, whenever there is a new SDK dev release, which tests the demo client with it. The normal test just uses the specified version in package.json / yarn.lock.
Tests are expected to fail for now. Will be handled after this PR was merged.