Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

feat: types for new delegation pallet (runtime version 17)#10

Merged
ntn-x2 merged 2 commits intomasterfrom
aa-new-delegation-types
Jul 29, 2021
Merged

feat: types for new delegation pallet (runtime version 17)#10
ntn-x2 merged 2 commits intomasterfrom
aa-new-delegation-types

Conversation

@ntn-x2
Copy link
Contributor

@ntn-x2 ntn-x2 commented Jul 19, 2021

fixes KILTProtocol/ticket#1451

Adds the new types for DelegationNode, DelegationHierarchy, and DelegationDetails.

How to test:

Try to create a new CTYPE hash and then a new delegation hierarchy. After that, you should be able to retrieve the correct delegation node info from the chain storage.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@ntn-x2 ntn-x2 requested review from rflechtner, tjwelde and wischli July 19, 2021 12:56
@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Jul 19, 2021

Adding also @tjwelde here as you are likely the one integrating the new types in the SDK.

@ntn-x2 ntn-x2 self-assigned this Jul 20, 2021
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Jul 29, 2021

Merging to use in SDK.

@ntn-x2 ntn-x2 merged commit c046877 into master Jul 29, 2021
@ntn-x2 ntn-x2 deleted the aa-new-delegation-types branch July 29, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants