Nazfib/check maths#8
Open
Nazfib wants to merge 3 commits into
Open
Conversation
Use the msbuild copy target instead of xcopy; change file encoding to utf-8.
- Use double precision quaternion - Make sure the orbit normal always points roughly northwards - The 'East' vector used to point to the west; - Replace latitude with abs(latitude) for checking against inclinations Fixes #7
|
Quite surprised that this hasn't been merged, this is an essential mod within the RP-1 suite, and having it not work for launch sites in the southern hemisphere is a pretty serious bug. (noticed this from https://discord.com/channels/319857228905447436/319857228905447436/1324677544670138410) |
|
I can confirm that this PR works without issues after testing btw, I forgot to mention that before. This is from Mahia, a southern hemisphere launch site: (ignore the additional fields, that's from here) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few small issues with the calculations. In particular, this makes it work from the southern hemisphere.
Fixes #7
Maybe fixes #6 ?