Skip to content

Make docking ports conserve momentum#160

Merged
gotmachine merged 1 commit into
KSPModdingLibs:devfrom
Jules-Bertholet:docking-ports-conserve-momentum
Sep 13, 2023
Merged

Make docking ports conserve momentum#160
gotmachine merged 1 commit into
KSPModdingLibs:devfrom
Jules-Bertholet:docking-ports-conserve-momentum

Conversation

@Jules-Bertholet
Copy link
Copy Markdown
Contributor

Averages the docking force between the two ports. This fixes the docking port Kraken drive and other unphysical behavior.

@gotmachine gotmachine added the kspBug Identified KSP issue label Sep 12, 2023
@gotmachine
Copy link
Copy Markdown
Contributor

Nice work, and thanks for the contribution.

However, could you please refactor this as a new, separate bugfix patch ?

While I agree this is a bug, and that fixing it by default would overall benefit to the vast majority of players, I would prefer to at least give the option of disabling it for the people wanting to mess around with the kraken drive thing, especially since it is wildly documented.

Averages the docking force between the two ports. This fixes the
[docking port Kraken drive](https://wiki.kerbalspaceprogram.com/wiki/Docking_Port_Drive)
and other unphysical behavior.
@Jules-Bertholet
Copy link
Copy Markdown
Contributor Author

Jules-Bertholet commented Sep 13, 2023

@gotmachine I've done as you requested.

@Jules-Bertholet Jules-Bertholet changed the base branch from master to dev September 13, 2023 17:12
@gotmachine gotmachine merged commit d7218b6 into KSPModdingLibs:dev Sep 13, 2023
@Jules-Bertholet Jules-Bertholet deleted the docking-ports-conserve-momentum branch September 13, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kspBug Identified KSP issue

Development

Successfully merging this pull request may close these issues.

2 participants