Skip to content

New perf patch: ForceSyncSceneSwitch#250

Merged
JonnyOThan merged 2 commits into
KSPModdingLibs:devfrom
siimav:SyncSceneChange
Oct 7, 2024
Merged

New perf patch: ForceSyncSceneSwitch#250
JonnyOThan merged 2 commits into
KSPModdingLibs:devfrom
siimav:SyncSceneChange

Conversation

@siimav
Copy link
Copy Markdown
Contributor

@siimav siimav commented Sep 6, 2024

Adds another change under the SceneLoadSpeedBoost umbrella. Forces all scene changes to happen synchronously which on some scenes can significantly lower load times. In my own testing with RP-1 I saw 4-4.5 seconds shaved off from SC -> VAB and VAB -> flight transitions. Others reported even 6-7s improvements.
The main speedup comes from asset cleanup running once instead of 3 times. However even if the async code path was forced to run cleanup only once, it was still close to 1s slower than the sync path.

@ValiusV
Copy link
Copy Markdown

ValiusV commented Sep 22, 2024

Hi! That sounds amazing. Would it be possible to have the compiled fix ? Because the official release is unlikely to happen soon..

@siimav
Copy link
Copy Markdown
Contributor Author

siimav commented Sep 22, 2024

I do have the same change available separately from KSPCF. Just drop the dll to the root of gamedata.
NoLoadingBuffer.zip

@ValiusV
Copy link
Copy Markdown

ValiusV commented Sep 23, 2024

Thanks ! It works really well and I haven’t encountered any problems yet.

I conducted a few performance tests with my heavily modded modpack. I repeated them several times in the same situations, and here are the results:
-KSC ->VAB: 12-13s without fix, 7-7.5s with fix
-VAB -> KSC: 16-18s without fix, same with fix (no improvement in this scene)
-VAB -> flight scene with a 100 parts ship: 36-38s without fix, 30-31s with fix

@siimav siimav changed the title Improve SceneLoadSpeedBoost patch New perf patch: ForceSyncSceneSwitch Sep 24, 2024
@JonnyOThan JonnyOThan changed the base branch from master to dev October 7, 2024 14:32
@JonnyOThan JonnyOThan merged commit ca50c98 into KSPModdingLibs:dev Oct 7, 2024
@siimav siimav deleted the SyncSceneChange branch October 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants