New perf patch: ForceSyncSceneSwitch#250
Merged
Merged
Conversation
|
Hi! That sounds amazing. Would it be possible to have the compiled fix ? Because the official release is unlikely to happen soon.. |
Contributor
Author
|
I do have the same change available separately from KSPCF. Just drop the dll to the root of gamedata. |
|
Thanks ! It works really well and I haven’t encountered any problems yet. I conducted a few performance tests with my heavily modded modpack. I repeated them several times in the same situations, and here are the results: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds another change under theForces all scene changes to happen synchronously which on some scenes can significantly lower load times. In my own testing with RP-1 I saw 4-4.5 seconds shaved off from SC -> VAB and VAB -> flight transitions. Others reported even 6-7s improvements.SceneLoadSpeedBoostumbrella.The main speedup comes from asset cleanup running once instead of 3 times. However even if the async code path was forced to run cleanup only once, it was still close to 1s slower than the sync path.