Adding support for Askpass and RSA#11
Open
evilmonkey19 wants to merge 3 commits intoKTH-SSAS:masterfrom
Open
Conversation
…itespaces and with password.
… timeout for slow computers
Author
|
Hello @BeethovenKodar, any news? :) |
Collaborator
|
Hello and nice contribution first off! Sorry for the late reply. I can't promise anything but I will try to spend some time in the upcoming months. I have just skimmed the changes this far but as a start I'd like to see the command line library change being submitted as a separate PR as it's orthogonal functionality compared to askpass/RSA. Hopefully get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hej,
I would to add support for askpass and RSA files. As well, I reduced the number of external dependencies to just one to make it easier to install.
Also, I have increased several timeout just to make sure that in slow computers (like mine) it works fine.
Finally, I added tests to make sure that everything passes.
Täck for this great library 🔝