Restructure Landmarking #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated tests - Updated documentation - Fixed typos in docs - Set llvm version to 3.3 for Travis
hkjeldsberg
commented
Aug 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 14 14
Lines 888 889 +1
=======================================
+ Hits 879 880 +1
Misses 9 9
Continue to review full report at Codecov.
|
aslakbergersen
suggested changes
Aug 26, 2020
Contributor
aslakbergersen
left a comment
aslakbergersen
left a comment
There was a problem hiding this comment.
Everything looks really very good. Nice and structured code! My comments are just minor changes.
morphman/automated_landmarking/automated_landmarking_bogunovic.py
Outdated
Show resolved
Hide resolved
- Separated find_interface methods for algorithms - Added missing docstrings - Use of numpy integration of vtk
Merged
aslakbergersen
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvmversion to 3.3 for Travis (Tests fail for latest versionllvm-10)vmtksurfacecurvature.py(Similar tovmtkcenterlines.py)