feat(#7): preserve URLs in descriptions and add --link flag#33
feat(#7): preserve URLs in descriptions and add --link flag#33
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c76073365
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let desc = stripMarkdown(options.description) || ''; | ||
| if (options.link) { | ||
| const linkLabel = options.linkText || 'Link'; | ||
| desc += (desc ? '\n\n' : '') + linkLabel + ': ' + options.link; | ||
| } |
There was a problem hiding this comment.
Preserve existing description when applying --link
When partiful update <id> --link ... is used without --description, the new code builds desc from options.description only and then patches description with just the generated link text, so any existing event description is overwritten. This is a destructive regression for events that already have details, because adding a link now drops prior content instead of appending to it.
Useful? React with 👍 / 👎.
Code Review Spec — PR #33 (links)[Important]
|
|
Stale — URL/link preservation already shipped in PR #43. This PR modifies the old monolith file. |
Summary
stripMarkdown()to preserve URLs (shows both link text and URL)--linkand--link-textflags tocreateandupdatecommandsCloses #7
Test plan
node partiful create --title "Test" --date "tomorrow" --link "https://example.com" --link-text "Zoom"appends link to descriptionstripMarkdown("[click](https://example.com)")returnsclick (https://example.com)🤖 Generated with Claude Code