Skip to content

feat(#7): preserve URLs in descriptions and add --link flag#33

Closed
KalebCole wants to merge 1 commit intomainfrom
feat/description-links
Closed

feat(#7): preserve URLs in descriptions and add --link flag#33
KalebCole wants to merge 1 commit intomainfrom
feat/description-links

Conversation

@KalebCole
Copy link
Copy Markdown
Owner

Summary

  • Fixes stripMarkdown() to preserve URLs (shows both link text and URL)
  • Adds --link and --link-text flags to create and update commands
  • URLs in descriptions are auto-linked by Partiful's web frontend

Closes #7

Test plan

  • node partiful create --title "Test" --date "tomorrow" --link "https://example.com" --link-text "Zoom" appends link to description
  • stripMarkdown("[click](https://example.com)") returns click (https://example.com)
  • Help text documents --link and --link-text flags

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c76073365

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +788 to +792
let desc = stripMarkdown(options.description) || '';
if (options.link) {
const linkLabel = options.linkText || 'Link';
desc += (desc ? '\n\n' : '') + linkLabel + ': ' + options.link;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve existing description when applying --link

When partiful update <id> --link ... is used without --description, the new code builds desc from options.description only and then patches description with just the generated link text, so any existing event description is overwritten. This is a destructive regression for events that already have details, because adding a link now drops prior content instead of appending to it.

Useful? React with 👍 / 👎.

@KalebCole
Copy link
Copy Markdown
Owner Author

Code Review Spec — PR #33 (links)

[Important] update --link without --description erases existing description

In updateEvent(), desc = stripMarkdown(options.description) || '' evaluates to empty when only --link is provided. The PATCH overwrites the existing description with just the link.

Fix: Fetch current event description via /getEvent before appending link when --description is not provided.

[Important] Emoji mismatch in docs

workflows.md shows link format with emoji prefix but implementation produces Link: https://... without emoji.

Fix: Remove emoji from workflows.md to match code.

@KalebCole
Copy link
Copy Markdown
Owner Author

Stale — URL/link preservation already shipped in PR #43. This PR modifies the old monolith file.

@KalebCole KalebCole closed this Mar 30, 2026
@KalebCole KalebCole deleted the feat/description-links branch March 30, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Add links in event description

1 participant