Skip to content

KRKPD-619 Adding site to Kargo adapter.#24

Merged
njflynn merged 6 commits intomasterfrom
KRKPD-619
Oct 5, 2023
Merged

KRKPD-619 Adding site to Kargo adapter.#24
njflynn merged 6 commits intomasterfrom
KRKPD-619

Conversation

@njflynn
Copy link

@njflynn njflynn commented Oct 2, 2023

Type of change

  • Bugfix

  • [ x] Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Adding support to Kargo adapter for site object

},
imp: impressions,
user: getUserIds(tdidAdapter, bidderRequest.uspConsent, bidderRequest.gdprConsent, firstBidRequest.userIdAsEids, bidderRequest.gppConsent),
site: firstBidRequest.site
Copy link

@juliangan07 juliangan07 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site is actually nested in another object ortb2.
i.e: firstBidRequest.ortb2.site

Sample query available in the ticket description.

@njflynn njflynn requested a review from juliangan07 October 4, 2023 11:35
},
imp: impressions,
user: getUserIds(tdidAdapter, bidderRequest.uspConsent, bidderRequest.gdprConsent, firstBidRequest.userIdAsEids, bidderRequest.gppConsent),
site: firstBidRequest.ortb2.site

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to add null checks for ortb2:

select
count(time_id_utc) as total
from stage_kraken_bid_request e
where time_id_utc = 2023100310
and e.src:data:body:bidRequest:prebidRawBidRequests[0] is not null
and e.src:data:body:bidRequest:prebidRawBidRequests[0]:ortb2 is null;

---------------------------------------------

TOTAL
33,079
select
count(time_id_utc) as total
from stage_kraken_bid_request e
where time_id_utc = 2023100310
and e.src:data:body:bidRequest:prebidRawBidRequests[0]:ortb2 is not null
and e.src:data:body:bidRequest:prebidRawBidRequests[0]:ortb2:site is null;

------------------------------------------------

TOTAL
0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link

@juliangan07 juliangan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, SF data suggests that when ortb2 is defined, site is always defined, but not the other way around.

Co-authored-by: Julian Gan  <juliangan07@gmail.com>
@njflynn njflynn requested a review from juliangan07 October 4, 2023 13:19
Copy link

@juliangan07 juliangan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@njflynn njflynn requested a review from jsadwith October 4, 2023 15:13
Copy link

@jsadwith jsadwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Neil.

@njflynn njflynn merged commit 203abca into master Oct 5, 2023
sj1815 pushed a commit that referenced this pull request Feb 27, 2024
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

* update minuteMediaBidAdapter - support missing params (#29)

* RIseBidAdapter: support currency (#35)

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: inna <innayare@gmail.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
sj1815 pushed a commit that referenced this pull request Feb 27, 2024
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

* update minuteMediaBidAdapter - support missing params (#29)

* add currency param to bid object and tests

* update getFloor function and tests

* adding test to currency param

* adding doc & currency bidfloor support & update tests

* update currency test

* remove default test

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: inna <innayare@gmail.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
sj1815 pushed a commit that referenced this pull request Feb 27, 2024
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

* update minuteMediaBidAdapter - support missing params (#29)

* support gpp for minutemedia adapter

* removed spaces

* removed extra character

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: YakirLavi <73641910+YakirLavi@users.noreply.github.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
Co-authored-by: Inna Yaretsky <>
jsadwith pushed a commit that referenced this pull request May 30, 2025
…rameters (prebid#13122)

* V 0 29 (#31)

* AGT-403: Add adType parameter to payload in report

* AGT-403: Test for partner report, adType parameter

* AGT-403: Test refactoring

* AGT-403: Documentation updated

* IntentIq Analytics Module: adUnitCode or placemetId to report (#9)

* AGT-446: adUnitCode or placemetId to report

* AGT-446: Description of changes, example

* AGT-446: Fix documentation

* AGT-446: Changes after review

* Agt 409 full url in prebid modules (#8)

* add sync

* update full url

* set url param

* fix comment

* fix issue fix sync mode

* update url

* update full url

* add test

* move browser_blacklist (#10)

* add is optedOut (#11)

* update date in FPD after sync (#12)

* update sync logic for new user (#13)

* fix unit tests

* change version name

* IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17)

* AGT-453: Support sourceMetaData

* AGT-453: sourceMetaDataExternal

* AGT-453: Documentation

* AGT-453: Changes after review

* AGT-453: Fix doc

* Fix doc

* AGT-453: Fix test

* update test

* update endpoint (#16)

* update endpoint

* update test

* add tests

* update test

* fix conflict

* fix conflict

* add test for reportingServerAddress

* add test for reportingServerAddress

* AGT-498: support report method parameter (#22)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: reportMethod parameter description (#23)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: Documentation

* Agt 452 server call counters (#18)

* add counters

* add unit tests and fixes

* counters additions

* clear counters when a request is made

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* add siloEnabled feature (#19)

* add siloEnabled feature

* add siloEnabled feature to analytics adapter

* add unit tests for siloEnabled feature

* add siloenabled to docs

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit test issues

* AGT-455: Source parameter in requests (#28)

* AGT-508: Spd parameter (#29)

* AGT-508: Spd parameter

* AGT-508: Move appendSpd to utils

* AGT-499: Support partnerClientIdType and partnerClientId (#30)

* AGT-499: partnerClientId and partnerClientIdType in requests

* AGT-499: Clean comment

* AGT-499: Refactoring

* add groupchanged parameter (#25)

* add groupchanged parameter

* fix md file issue

* add groupChanged example in docs

* remove group from example

* add unit tests and fix groupChanged issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* Agt 501 support additional params (#24)

* additionalParams feature init

* additional params add features

* additionalparams fix analytics adapter

* add unit tests for additionalParams

* fix currentBrowser issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* fix linter error

---------

Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit tests (#32)

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* Agt 547 vr bug for module (#33)

* save progress

* fix calling server

* add "dbsaved" parameter

* add tests

* AGT-552: Additional query params (#34)

* AGT-552: Additional query params

* update documentation

---------

Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>

* Fix unit test for specific browser

* fix spelling

---------

Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com>
Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments