Skip to content

fix: explicitly use float32 for numpy typing #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wbthomason merged 1 commit into from
Sep 12, 2024
Merged

fix: explicitly use float32 for numpy typing #27

wbthomason merged 1 commit into from
Sep 12, 2024

Conversation

@zkingston
Copy link
Collaborator

@zkingston zkingston commented Sep 12, 2024

In the latest numpy versions, there is no float_ type. Just explicitly marking the type as float32.

wbthomason
wbthomason approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@wbthomason wbthomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@wbthomason wbthomason merged commit 53a7bd2 into main Sep 12, 2024
@wbthomason wbthomason deleted the fix-numpy-typing branch September 12, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbthomason wbthomason wbthomason approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zkingston @wbthomason