Support for serde rename(_all) and flatten #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've never written proc macros before, please point out if i used a non-idiomatic and/or ineffective approach somewhere |
Author
|
Pure |
DarkCat09
commented
Jan 29, 2026
| let mut res = None; | ||
| meta.parse_nested_meta(|meta| { | ||
| let value = meta.value()?; | ||
| let s: LitStr = value.parse()?; |
Author
There was a problem hiding this comment.
Parsing = & LitStr tokens is required no matter whether we get deserialize ident or not, because otherwise we leave the parser at the same position and don't get valid next attribute tokens on the next loop iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306