Skip to content

Fix websocket connection leak during authentication #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sk-keeper merged 3 commits into from
Nov 13, 2025
Merged

Fix websocket connection leak during authentication #92

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8364e1c
Fix asyncio event loop cleanup with SSO auth
m-k8s Nov 13, 2025
1988b20
Revert "Fix asyncio event loop cleanup with SSO auth"
m-k8s Nov 13, 2025
1e0985c
Close login websocket after authentication
m-k8s Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions keepersdk-package/src/keepersdk/authentication/login_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,11 @@ def _on_logged_in(login: LoginAuth, response: APIRequest_pb2.LoginResponse,
auth_context.device_private_key = login.context.device_private_key
auth_context.message_session_uid = login.context.message_session_uid

# Close login-time push notifications
if login.push_notifications:
login.push_notifications.shutdown()
login.push_notifications = None

keeper_endpoint = login.keeper_endpoint
logged_auth = keeper_auth.KeeperAuth(keeper_endpoint, auth_context)
logged_auth.post_login()
Expand Down