Skip to content

Conversation

@dbclkh
Copy link
Contributor

@dbclkh dbclkh commented May 25, 2023

The change was "to mitigate problems with functions conflicting between global and local copies of the package"...

dbclkh added 3 commits May 25, 2023 07:05
The inspect_all function has been replaced with a Utils::inspect_all function due to "mitigate problems with functions conflicting between global and local copies of the package".
The name of the new function is inspectAll and not inspect_all...
Make promises accept both version 1.4 or 2.0.

Co-authored-by: Christoph Reiter <reiter.christoph@gmail.com>
@dbclkh
Copy link
Contributor Author

dbclkh commented May 26, 2023

@Kevinrob - when you've got the time - please have a look at this PR. :-)

Copy link
Owner

@Kevinrob Kevinrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kevinrob
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants