Bump default version number.#1161
Merged
MarkCallow merged 9 commits intomainfrom Apr 24, 2026
Merged
Conversation
* Move misplaced `fi` to correct place and fix indentation. * Add lib/src to target directories.
that resulted an extra space in edited KTXwriterScParams.
Check all color models, not just ASTC, for FLOAT qualifier.
Update to test_decode_astc() due to input file changing to SFLOAT after regeneration.
richgel999
added a commit
to BinomialLLC/KTX-Software-Binomial-Fork
that referenced
this pull request
Apr 25, 2026
Various other issues were encountered and fixed while checking the version number related changes. 1. Fix `-a` option of `mkversion`. It did not visit `lib/src` and ended with an error due to a misplaced `fi`. 2. Fix RE in _ktx convert_ that resulted in an extra space in an edited KTXwriterScParams when the original `zcmp` option had a parameter. 3. Fix `ktxTexture2_IsHDR` which was only checking for a FLOAT qualifier on DFD samples for the ASTC color model. Add a test for it. Fixes KhronosGroup#1112. # Conflicts: # interface/python_binding/tests/test_ktx_texture2.py # tests/resources/ktx2/Desk_small_zstd_15.ktx2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various other issues were encountered and fixed while checking the version number related changes.
-aoption ofmkversion. It did not visitlib/srcand ended with an error due to a misplacedfi.zcmpoption had a parameter.ktxTexture2_IsHDRwhich was only checking for a FLOAT qualifier on DFD samples for the ASTC color model. Add a test for it.Fixes #1112.