Add cl_ext_immutable_memory_objects tests writing to and from buffer
#2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
reviewed
Sep 16, 2025
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
I don't have access to a system to test these changes, but here are a few things I noticed reading through the code.
test_conformance/buffers/testBase.h
Outdated
Comment on lines
30
to
32
| extern const cl_mem_flags immutable_flag_set[]; | ||
| extern const char* immutable_flag_set_names[]; | ||
| #define NUM_IMMUTABLE_FLAGS 3 |
Contributor
There was a problem hiding this comment.
I find this confusing.
- Why is
NUM_FLAGSequal to 5 when there are 8 entries in the array? - Why are there separate arrays for immutable flags that are used sometimes, but not every time?
Could we have a single array instead and filter based on the flags we care about testing?
Alternatively, could we have two distinct arrays, and iterate over both if we want to test both mutable and immutable flags?
Contributor
Author
There was a problem hiding this comment.
I followed the first option; a single array with all available flags to test. Updated buffer test suite existing tests to skip to new flags whenever needed.
MichaelRizkalla-arm
force-pushed
the
cl_ext_immutable_memory_objects_tests_part_2_buffers
branch
from
f37293a to
6d388d7
Compare
The change tests: 1. Writing to immutable buffers. 2. Writing to buffer/image from immutable buffers. 3. Reading from immutable buffers. This change adds the following tests: 1. `test_negative_imagearraycopy` 2. `test_negative_imagearraycopy3d` 3. `test_immutable_bufferreadwriterect` 4. `test_immutable_arrayreadwrite` 5. `test_write_from_immutable_buffer_to_buffer` 6. `test_immutable_buffer_map_*` and extends the following tests: 1. `test_arrayimagecopy3d` 2. `test_arrayimagecopy` 3. `test_imagearraycopy3d` 4. `test_imagearraycopy` 5. `test_buffer_copy` 6. `test_buffer_partial_copy` Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com>
MichaelRizkalla-arm
force-pushed
the
cl_ext_immutable_memory_objects_tests_part_2_buffers
branch
from
6d388d7 to
5377c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the test coverage for KhronosGroup/OpenCL-Docs#1280
The change tests:
This change adds the following tests:
test_negative_imagearraycopytest_negative_imagearraycopy3dtest_immutable_bufferreadwriterecttest_immutable_arrayreadwritetest_write_from_immutable_buffer_to_buffertest_immutable_buffer_map_*and extends the following tests:
test_arrayimagecopy3dtest_arrayimagecopytest_imagearraycopy3dtest_imagearraycopytest_buffer_copytest_buffer_partial_copy