Skip to content

Fix test_atomics - wrong HostDataType taken for comparing #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gwawiork wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix test_atomics - wrong HostDataType taken for comparing #2601

gwawiork wants to merge 1 commit into from

Conversation

@gwawiork
Copy link
Contributor

@gwawiork gwawiork commented Dec 30, 2025

We see compiler errors on Intel GPU without this fix.

@gwawiork
Copy link
Contributor Author

gwawiork commented Dec 30, 2025

@shajder I am not sure of this fix. Now in test output instead
local atomic_half
I see
local atomic_intptr_t

@shajder
Copy link
Contributor

shajder commented Jan 7, 2026

@shajder I am not sure of this fix. Now in test output instead local atomic_half I see local atomic_intptr_t

Thanks, your finding is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shajder shajder shajder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gwawiork @shajder