Fix typedef redefinition warnings #1840
Merged
+8
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 616208. |
|
CI Vulkan-Loader build queued with queue ID 616225. |
Closed
|
CI Vulkan-Loader build # 3361 running. |
|
CI Vulkan-Loader build # 3361 passed. |
C99 does not support redefining typedefs and so the code should avoid doing that as necessary. Also it turns out #if !defined(<typedef>) does not actually protect the inner value, since typedef does not operate on semantic constructs.
charles-lunarg
force-pushed
the
fix_typedef_redefinitions
branch
from
932f61c to
92b0f4e
Compare
|
CI Vulkan-Loader build queued with queue ID 616399. |
|
CI Vulkan-Loader build queued with queue ID 616416. |
|
CI Vulkan-Loader build # 3363 running. |
|
CI Vulkan-Loader build # 3363 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C99 does not support redefining typedefs and so the code should avoid doing that as necessary.
Also it turns out #if !defined() does not actually protect the inner value, since typedef does not operate on semantic constructs.