Add librt when necessary#149
Merged
Merged
Conversation
| cube.vert.inc | ||
| cube.frag.inc) | ||
| target_link_libraries(vkcube Vulkan::Vulkan) | ||
| if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") |
There was a problem hiding this comment.
Is this CMAKE_SYSTEM_NAME check actually required? By the outer if-else tree, it's already !APPLE and !WIN32.
Change-Id: Ie4b3fdec4d61a52e82880308bb567f2f22c6c273
TonyBarbour
force-pushed
the
tony-cmake-rt
branch
from
233bb66 to
0795fec
Compare
|
Yes this patch fixes my problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to be a little more conservative than #148 francoisbertelatschrodinger could you see if this fixes your problem?