vkcube: Replace MoltenVK surfaces with Metal#297
Merged
jeremyk-lunarg merged 1 commit intomasterfrom Dec 2, 2019
Merged
Conversation
Made DemoViewController.m compatible with VK_EXT_metal_surface extension and replaced all references to VK_MVK_macos_surface and VK_MVK_ios_surface with VK_EXT_metal_surface. Change-Id: I4a163bc9c6109b44d169c6565313ab52161d38fc
jeremyk-lunarg
force-pushed
the
jeremyk-billhollings_vkcube_use_metal_surface
branch
from
7e422a9 to
ef4abd9
Compare
billhollings
approved these changes
Nov 28, 2019
Contributor
billhollings
left a comment
billhollings
left a comment
There was a problem hiding this comment.
I've tested this with the MoltenVK Cube demo and all looks good!
jeremyk-lunarg
deleted the
jeremyk-billhollings_vkcube_use_metal_surface
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made DemoViewController.m compatible with VK_EXT_metal_surface
extension and replaced all references
to VK_MVK_macos_surface and VK_MVK_ios_surface with
VK_EXT_metal_surface.
PR #220 cherry-picked and rebased onto master.
I also modified vkcubepp to use VK_EXT_metal_surface.