Skip to content

layers: Fix NV RTX bug #10985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spencer-lunarg merged 1 commit into from
Nov 3, 2025
+4 −2
Merged

layers: Fix NV RTX bug #10985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion layers/core_checks/cc_ray_tracing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2730,7 +2730,9 @@ bool CoreChecks::ValidateClusterAccelerationStructureCommandsInfoNV(
case VK_CLUSTER_ACCELERATION_STRUCTURE_OP_TYPE_MAX_ENUM_NV:
break;
}
if (command_infos.srcInfosArray.stride < stride_min) {

// "If the stride is 0, the structures are assumed to be packed tightly"
if (command_infos.srcInfosArray.stride < stride_min && command_infos.srcInfosArray.stride != 0) {
skip |= LogError("VUID-VkClusterAccelerationStructureCommandsInfoNV-srcInfosArray-10476", objlist,
command_infos_loc.dot(Field::srcInfosArray).dot(Field::stride),
"(%" PRIu64 ") must be greater than size of %s (%" PRIu32 ")", command_infos.srcInfosArray.stride,
Expand Down
2 changes: 1 addition & 1 deletion layers/state_tracker/state_tracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2455,7 +2455,7 @@ void DeviceState::PostCallRecordCmdBindPipeline(VkCommandBuffer commandBuffer, V
auto cb_state = GetWrite<CommandBuffer>(commandBuffer);
cb_state->RecordCommand(record_obj.location);
auto pipeline_state = Get<Pipeline>(pipeline);
ASSERT_AND_RETURN(pipeline);
ASSERT_AND_RETURN(pipeline_state);
Copy link
Copy Markdown
Contributor Author

@spencer-lunarg spencer-lunarg Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arno-lunarg fyi, fixing this here too

cb_state->RecordBindPipeline(pipelineBindPoint, *pipeline_state);

if (!disabled[command_buffer_state]) {
Expand Down