Revert "Add Validation for VK_KHR_create_renderpass2"#429
Closed
jzulauf-lunarg wants to merge 3 commits into
Closed
Revert "Add Validation for VK_KHR_create_renderpass2"#429jzulauf-lunarg wants to merge 3 commits into
jzulauf-lunarg wants to merge 3 commits into
Conversation
Contributor
Author
|
@Tobski crashes on tests VkLayerTest.RenderPassEndBeforeFinalSubpass |
Contributor
|
I think these were known failures that skipped our filters due to renaming tests. |
Contributor
Author
|
Filters to be updated to eliminate failures in renamed tests. |
Contributor
|
Oh - so is this OK then? How come I didn't see this in the CI for the PR btw - is there some extra CI that you only run on master? |
Contributor
Author
|
@Tobski -- Yes, there are some non-public CI environments, this one with a known-failures list that filters by testname. The changed test names happened to be on that list. The moral is "don't change test names without checking with all CI environments and maybe not even then." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #357
Issues with Android 8.x CI testing.