Skip to content

Set gl_PointSize in primitive restart tests for GL_POINTS.#3368

Merged
kdashg merged 1 commit intoKhronosGroup:mainfrom
kenrussell:primitiverestart-set-pointsize
Dec 6, 2021
Merged

Set gl_PointSize in primitive restart tests for GL_POINTS.#3368
kdashg merged 1 commit intoKhronosGroup:mainfrom
kenrussell:primitiverestart-set-pointsize

Conversation

@kenrussell
Copy link
Member

Failing to set this was relying on currently-undefined behavior and
causing the tests to fail on Apple's M1.

Related to #2818, #2822 and #3356.

Failing to set this was relying on currently-undefined behavior and
causing the tests to fail on Apple's M1.

Related to KhronosGroup#2818, KhronosGroup#2822 and KhronosGroup#3356.
@kenrussell kenrussell requested review from greggman and kdashg December 4, 2021 02:36
@kenrussell
Copy link
Member Author

@greggman or @jdashg please review - thanks.

This has been confirmed to fix these tests on Apple's M1.

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kdashg kdashg merged commit aa1e61d into KhronosGroup:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants