Validate error for out-of-bounds active texture#3757
Merged
kenrussell merged 2 commits intoKhronosGroup:mainfrom Feb 19, 2026
Merged
Validate error for out-of-bounds active texture#3757kenrussell merged 2 commits intoKhronosGroup:mainfrom
kenrussell merged 2 commits intoKhronosGroup:mainfrom
Conversation
Added check for out-of-bounds texture unit error.
|
|
Contributor
Author
|
Works as expected in edge, firefox reports wrong INVALID_VALUE instead of INVALID_ENUM |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 16, 2026
…_COMBINED_TEXTURE_IMAGE_UNITS) (#42660) #42639 was actually the real issue, just solved less ideally. Instead of doing negative checks, which are easy to go wrong like before, we know do positive check which is more clear IMO. Because counting of units is 0-based, we need to not include upper limit. WebGL spec is a mess, so I will rather link this MDN: https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/activeTexture#exceptions Testing: Added test to WebGL CTS: KhronosGroup/WebGL#3757, live at: https://sagudev.github.io/WebGL/sdk/tests/conformance/textures/misc/texture-active-bind.html Fixes: #42639 Co-authored-by: Weixie Cui <cuiweixie@gmail.com> Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 16, 2026
…_COMBINED_TEXTURE_IMAGE_UNITS) (#42660) #42639 was actually the real issue, just solved less ideally. Instead of doing negative checks, which are easy to go wrong like before, we know do positive check which is more clear IMO. Because counting of units is 0-based, we need to not include upper limit. WebGL spec is a mess, so I will rather link this MDN: https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/activeTexture#exceptions Testing: Added test to WebGL CTS: KhronosGroup/WebGL#3757, live at: https://sagudev.github.io/WebGL/sdk/tests/conformance/textures/misc/texture-active-bind.html Fixes: #42639 Co-authored-by: Weixie Cui <cuiweixie@gmail.com> Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Member
|
Thanks for this contribution; the error verified here matches the manual page and what ANGLE validates as well. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant MDN: https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/activeTexture#exceptions
live: https://sagudev.github.io/WebGL/sdk/tests/conformance/textures/misc/texture-active-bind.html