Skip to content

Conversation

@raja-grewal
Copy link
Contributor

Reduces attack surface by expanding the list of disabled kernel modules relating to file systems, GPS, network file systems, network protocols/drivers, Thunderbolt, and some miscellaneous drivers. Also provides option to disable more Bluetooth modules.

Applies some suggestions in Issue #224.

Changes

Updated security-misc.maintscript.

Moved some previously blacklisted modules to the disabled list.

Replacesdisabled-vivid-by-security-misc with a more general disabled-miscellaneous-by-security-misc that can be used for other modules.

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@raja-grewal
Copy link
Contributor Author

rm_conffile /etc/permission-hardening.d/30_default.conf

## repalced with /usr/bin/disabled-miscellaneous-by-security-misc
rm_conffile /usr/bin/disabled-vivid-by-security-misc No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 lines need to be removed.

Only files in /etc need to be added to maintscript because these are configuration files and handled different by dpkg. Files in other locations such as folder /usr must not be added there.

(Otherwise a newline at end would be needed too.)

Not a big deal. I can undo this after merge.

@adrelanos
Copy link
Member

adrelanos commented Jul 15, 2024

What is the rationale for disabling...?

install brcm80211 /usr/bin/disabled-network-by-security-misc
install eepro100 /usr/bin/disabled-network-by-security-misc
install eth1394 /usr/bin/disabled-network-by-security-misc

Could not find any references.

install atm /usr/bin/disabled-network-by-security-misc
install ueagle-atm /usr/bin/disabled-network-by-security-misc
install usbatm /usr/bin/disabled-network-by-security-misc
install xusbatm /usr/bin/disabled-network-by-security-misc

ADSL USB modems might still be in use?

@adrelanos
Copy link
Member

I will merge this but comment these out pending further discussion and potential comment in later.

adrelanos added a commit that referenced this pull request Jul 15, 2024
@adrelanos adrelanos closed this in fe0846c Jul 15, 2024
@adrelanos adrelanos merged commit 41f0b53 into Kicksecure:master Jul 15, 2024
@raja-grewal
Copy link
Contributor Author

The following two modules had already been blacklisted by us in 61ef9bd for about two years and as far as I am aware there have been no complaints. They were originally sourced from Ubuntu's /etc/modprobe.d/*`.

install eepro100 /usr/bin/disabled-network-by-security-misc
install eth1394 /usr/bin/disabled-network-by-security-misc

Regarding brcm80211 and atm, continue discussion at #224 (comment).

@adrelanos
Copy link
Member

adrelanos commented Jul 16, 2024 via email

@raja-grewal
Copy link
Contributor Author

ADSL USB modems might still be in use?

Note that disabling atm also disables those 3 corresponding modules as well.

See:

[u@p]$ doas modprobe ueagle-atm
sh: line 1: /usr/bin/disabled-network-by-security-misc: No such file or directory
modprobe: ERROR: Error running install command '/usr/bin/disabled-network-by-security-misc' for module atm: retcode 127
modprobe: ERROR: could not insert 'ueagle_atm': Invalid argument
[u@p]$ doas modprobe usbatm
sh: line 1: /usr/bin/disabled-network-by-security-misc: No such file or directory
modprobe: ERROR: Error running install command '/usr/bin/disabled-network-by-security-misc' for module atm: retcode 127
modprobe: ERROR: could not insert 'usbatm': Invalid argument
[u@p]$ doas modprobe xusbatm
sh: line 1: /usr/bin/disabled-network-by-security-misc: No such file or directory
modprobe: ERROR: Error running install command '/usr/bin/disabled-network-by-security-misc' for module atm: retcode 127
modprobe: ERROR: could not insert 'xusbatm': Invalid argument

ATM has been disabled for over two years and so I don't see why we need to comment out those 3 since they have not worked since then.

Therefore, for the time being I am going to 'disable' them again so users do not get confused as to what is going on.

@raja-grewal raja-grewal deleted the kernel_modules branch July 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants