Merged
Conversation
Previously, creating a Gotcha instance with custom types required the awkward syntax: Gotcha::<(), ()>::with_types::<AppState, AppConfig>() This commit improves the API by moving type construction methods to a non-generic impl block, allowing for cleaner syntax: Gotcha::with_types::<AppState, AppConfig>() Gotcha::with_state::<AppState>() Gotcha::with_config::<AppConfig>() Benefits: - No more confusing <(), ()> type parameters - Cleaner, more intuitive API - Better developer experience - Maintains backward compatibility Added comprehensive tests and examples demonstrating the new API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the awkward
<(), ()>type syntax requirement when creating Gotcha instances with custom types.Previously, creating a Gotcha instance with custom state and config required specifying dummy type parameters:
Gotcha::<(), ()>::with_types::<AppState, AppConfig>(). This change improves the API by moving type construction methods to a non-generic impl block, allowing cleaner syntax:Gotcha::with_types::<AppState, AppConfig>(), plus convenience methodswith_state()andwith_config()for single-type scenarios.Added comprehensive tests and examples demonstrating the new API patterns. All existing code continues to work unchanged.
🧪 Generated with Claude Code