Summary
The reconciler replaced all patrol, scheduling, and review-queue alarm functions in Phases 3-4. The old code is still present (~2500 lines) with DEAD CODE comments but is never called from the alarm loop. Delete it to reduce confusion and binary size.
Files to clean up
src/dos/town/patrol.ts (~789 lines) — Keep: createTriageRequest, countPendingTriageRequests, listPendingTriageRequests, TRIAGE_LABEL_LIKE, TRIAGE_REQUEST_LABEL, TRIAGE_BATCH_LABEL, GUPP/GC constants. Delete: detectStaleHooks, feedStrandedConvoys, rehookOrphanedBeads, detectCrashLoops, detectOrphanedWork, agentGC, checkTimerGates, detectGUPPViolations.
src/dos/town/scheduling.ts (~374 lines) — Keep: hasActiveWork, dispatchAgent, dispatchUnblockedBeads, constants. Delete: schedulePendingWork and sub-functions.
src/dos/town/review-queue.ts (~1191 lines) — Keep: submitToReviewQueue, setReviewPrUrl, markReviewInReview, completeReviewWithResult, agentDone, agentCompleted, listPendingPRReviews, molecule functions. Delete: recoverStuckReviews, closeOrphanedReviewBeads, recoverOrphanedSourceBeads, popReviewQueue.
src/dos/Town.do.ts — Delete: witnessPatrol(), deaconPatrol(), processReviewQueue(), processConvoyLandings(), failReviewWithRework(), pollPendingPRs().
Acceptance Criteria
Summary
The reconciler replaced all patrol, scheduling, and review-queue alarm functions in Phases 3-4. The old code is still present (~2500 lines) with
DEAD CODEcomments but is never called from the alarm loop. Delete it to reduce confusion and binary size.Files to clean up
src/dos/town/patrol.ts(~789 lines) — Keep:createTriageRequest,countPendingTriageRequests,listPendingTriageRequests,TRIAGE_LABEL_LIKE,TRIAGE_REQUEST_LABEL,TRIAGE_BATCH_LABEL, GUPP/GC constants. Delete:detectStaleHooks,feedStrandedConvoys,rehookOrphanedBeads,detectCrashLoops,detectOrphanedWork,agentGC,checkTimerGates,detectGUPPViolations.src/dos/town/scheduling.ts(~374 lines) — Keep:hasActiveWork,dispatchAgent,dispatchUnblockedBeads, constants. Delete:schedulePendingWorkand sub-functions.src/dos/town/review-queue.ts(~1191 lines) — Keep:submitToReviewQueue,setReviewPrUrl,markReviewInReview,completeReviewWithResult,agentDone,agentCompleted,listPendingPRReviews, molecule functions. Delete:recoverStuckReviews,closeOrphanedReviewBeads,recoverOrphanedSourceBeads,popReviewQueue.src/dos/Town.do.ts— Delete:witnessPatrol(),deaconPatrol(),processReviewQueue(),processConvoyLandings(),failReviewWithRework(),pollPendingPRs().Acceptance Criteria