Skip to content

fix(code-reviews): fix incremental review flag and add logging #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-alecu merged 2 commits into from
Mar 18, 2026
Merged

fix(code-reviews): fix incremental review flag and add logging #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
428b8ad
fix(code-reviews): pass owner id to incremental flag
alex-alecu Mar 18, 2026
77c22dd
fix(code-reviews): log incremental review decisions
alex-alecu Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/lib/code-reviews/prompts/generate-prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,22 @@ export async function generateReviewPrompt(
.replace(/{PREVIOUS_SUMMARY}/g, existingReviewState.summaryComment.body)
.replace(/{ACTIVE_COMMENT_COUNT}/g, String(activeCount));
prompt += replacePlaceholders(incrementalWorkflow) + '\n\n';
logExceptInTest('[generateReviewPrompt] Using incremental workflow', {
reviewId,
previousHeadSha: previousHeadSha.substring(0, 8),
});
} else {
prompt += replacePlaceholders(template.workflow) + '\n\n';
if (previousHeadSha) {
logExceptInTest(
'[generateReviewPrompt] Falling back to full workflow despite previousHeadSha',
{
reviewId,
hasIncrementalTemplate: !!template.incrementalReviewWorkflow,
hasSummaryComment: !!existingReviewState?.summaryComment,
}
);
}
}

// 6. What to review
Expand Down
16 changes: 15 additions & 1 deletion src/lib/code-reviews/triggers/prepare-review-payload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,16 @@ export async function prepareReviewPayload(
// continuation) are derived from the same review row to avoid mismatches.
let previousHeadSha: string | null = null;
let previousCloudAgentSessionId: string | undefined;
const incrementalEnabled = await isFeatureFlagEnabled(FEATURE_FLAG_INCREMENTAL_REVIEW);
const incrementalEnabled = await isFeatureFlagEnabled(
FEATURE_FLAG_INCREMENTAL_REVIEW,
owner.userId
);

logExceptInTest('[prepareReviewPayload] Incremental review flag evaluated', {
reviewId,
incrementalEnabled,
ownerId: owner.userId,
});

if (incrementalEnabled) {
try {
Expand All @@ -345,6 +354,11 @@ export async function prepareReviewPayload(
previousCloudAgentSessionId,
}
);
} else {
logExceptInTest(
'[prepareReviewPayload] No previous completed review found, using full review',
{ reviewId }
);
}
} catch (error) {
// Non-critical - fall back to full review
Expand Down
Loading