-
Notifications
You must be signed in to change notification settings - Fork 37
feat(gastown): add debug dry-run endpoint with event draining #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrf0110
merged 6 commits into
convoy/reconciler-phase-5-debug-endpoints-grafa/4763028e/head
from
gt/toast/c127ebe8
Mar 21, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d5d0546
feat(claw): evaluate button-vs-card feature flag for PostHog experime…
kilo-code-bot[bot] 4c75b0b
fix(claw): move button-vs-card flag eval to CreateInstanceCard
pedroheyerdahl 71b9446
feat(claw): evaluate button-vs-card feature flag for PostHog experime…
pedroheyerdahl af17a15
feat(gastown): add POST /debug/reconcile-dry-run endpoint
jrf0110 26c6fc4
fix(gastown): drain pending events in debugDryRun() before reconciling
jrf0110 ab8785b
Merge branch 'convoy/reconciler-phase-5-debug-endpoints-grafa/4763028…
jrf0110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Dry run no longer matches the real alarm loop when an event is bad
debugDryRun()now applies each drained event without the per-eventtry/catchthat the real alarm loop uses incloudflare-gastown/src/dos/Town.do.ts:2938. If one pending event throws here, the whole endpoint returns an error and you never see the reconcile actions for the remaining queue, even though the actual alarm tick would log the failure, skip that event, and continue. That makes this preview unreliable հենց when the queue contains the malformed event you're trying to inspect.