Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routers/kiloclaw-router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,7 @@ export const kiloclawRouter = createTRPCRouter({
const gmailPushFlag = isDev ? ' --gmail-push-worker-url=${GMAIL_PUSH_WORKER_URL}' : '';
const imageUrl = `ghcr.io/kilo-org/google-setup${imageTag}`;
return {
command: `docker pull ${imageUrl} && docker run -it --network host ${imageUrl} --token="${token}"${workerFlag}${gmailPushFlag}`,
command: `docker pull ${imageUrl} ; docker run -it --network host ${imageUrl} --token="${token}"${workerFlag}${gmailPushFlag}`,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: docker run still executes after a failed pull

Using ; here means the second command runs even when docker pull fails. That can start the setup flow from a stale local ghcr.io/kilo-org/google-setup image and hide the real pull error, so the command no longer preserves the original "run only after a successful pull" behavior.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run will fail, so this is fine

};
}),

Expand Down
Loading